Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format all code with black and isort #218

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Format all code with black and isort #218

merged 5 commits into from
Oct 2, 2023

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Oct 2, 2023

  • Formats all code with black using default rules except line length of 120 (instead of 88)
  • Formats all code with isort to organize imports
  • Adds VS Code settings to enable automatic formatting

@t1m0thyj t1m0thyj marked this pull request as draft October 2, 2023 14:38
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/core/zowe/core_for_zowe_sdk/__init__.py 100.00% <100.00%> (ø)
src/core/zowe/core_for_zowe_sdk/connection.py 100.00% <100.00%> (ø)
src/core/zowe/core_for_zowe_sdk/constants.py 100.00% <ø> (ø)
.../core/zowe/core_for_zowe_sdk/credential_manager.py 92.22% <100.00%> (-0.09%) ⬇️
src/core/zowe/core_for_zowe_sdk/request_handler.py 80.39% <100.00%> (-0.74%) ⬇️
src/core/zowe/core_for_zowe_sdk/sdk_api.py 96.29% <100.00%> (ø)
src/core/zowe/core_for_zowe_sdk/session.py 95.34% <100.00%> (ø)
src/core/zowe/core_for_zowe_sdk/validators.py 71.42% <100.00%> (ø)
...s_console/zowe/zos_console_for_zowe_sdk/console.py 66.66% <ø> (ø)
.../zos_files/zowe/zos_files_for_zowe_sdk/__init__.py 100.00% <100.00%> (ø)
... and 16 more

📢 Thoughts on this report? Let us know!.

@t1m0thyj t1m0thyj marked this pull request as ready for review October 2, 2023 14:59
traeok
traeok approved these changes Oct 2, 2023
View reviewed changes
src/core/zowe/core_for_zowe_sdk/exceptions.py Outdated Show resolved Hide resolved
src/core/zowe/core_for_zowe_sdk/profile_manager.py Outdated Show resolved Hide resolved
@t1m0thyj
Address PR feedback
27061c9 
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj requested a review from traeok October 2, 2023 18:42
traeok
traeok approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing those comments @t1m0thyj 😋 LGTM!

@t1m0thyj t1m0thyj merged commit c52e836 into main Oct 2, 2023
19 of 20 checks passed
@t1m0thyj t1m0thyj deleted the format-black-isort branch October 2, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traeok traeok traeok approved these changes

@zFernand0 zFernand0 zFernand0 approved these changes

@awharn awharn Awaiting requested review from awharn

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t1m0thyj @zFernand0 @traeok